Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing i10n text at vessel view #264

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Fix missing i10n text at vessel view #264

merged 1 commit into from
Oct 5, 2020

Conversation

mdegis
Copy link
Contributor

@mdegis mdegis commented Oct 4, 2020

Related Issue

Fixes #262

Checklist:

  • I have read the contributor's guide.
  • I linked an issue in the previous section
  • I have commented on the linked issue
  • I was assigned the linked issue (not required)
  • I have tested the change to the best of my ability against the sandbox or a local build.

Optional items:

  • My change adds new text and requires a change to translations.
  • My change requires a change to the documentation.
  • I have submitted a PR to the documentation repo.
  • I was not able to test... (explain below, e.g. you did not have permissions to test a specific feature)
  • This change depends O-FISH Realm repository changes (explain below)

At the issue, missing translation key are stated as:

  • PERMIT_NUMBERS
  • FLAG_STATES
  • HOME_PORTS
  • CAPTAINS

However, when I've check the code, I've notice that PERMIT_NUMBERS usage is not plural. It is "Permit Number" and the file already has this key:

"PERMIT_NUMBER": "Permit Number",

"PERMIT_NUMBER": "Numéro de Permis",

So other three is added for both en and fr and vessel-view is update to use this new keys.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting your first PR to this repository. We appreciate your contribution! Our team will review your code within 3 business days. We <3 open source and are so glad you do, too!

@Sheeri Sheeri self-requested a review October 5, 2020 16:41
Copy link
Collaborator

@Sheeri Sheeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks so much!

Screen Shot 2020-10-05 at 12 41 30 PM

And the English:

Screen Shot 2020-10-05 at 12 42 49 PM

@Sheeri Sheeri merged commit 4dafba2 into WildAid:main Oct 5, 2020
@Sheeri
Copy link
Collaborator

Sheeri commented Oct 5, 2020

Congratulations! 🎉 🙌 🎆 ㊗️

This PR is great and has been merged into the code. Thanks so much for contributing! If you'd like, you can request to work on another issue. We really appreciate your effort!

@Sheeri
Copy link
Collaborator

Sheeri commented Oct 19, 2020

Hi @mdegis!
We noticed you haven't claimed your digital MongoDB swag. To claim your O-FISH badge, head on over to the MongoDB Community forums, login, and reply - making sure to link to this PR.

@mdegis
Copy link
Contributor Author

mdegis commented Oct 19, 2020

Hi @mdegis!
We noticed you haven't claimed your digital MongoDB swag. To claim your O-FISH badge, head on over to the MongoDB Community forums, login, and reply - making sure to link to this PR.

Cool! I did not know that I can claim O-FISH badge. Thank you for letting me know 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internationalize fields on vessel view page
2 participants