Fix missing i10n text at vessel view #264
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #262
Checklist:
Optional items:
At the issue, missing translation key are stated as:
However, when I've check the code, I've notice that
PERMIT_NUMBERS
usage is not plural. It is "Permit Number" and the file already has this key:o-fish-web/src/helpers/i18n/en/translation.json
Line 174 in 5a4fe43
o-fish-web/src/helpers/i18n/fr/translation.json
Line 173 in 5a4fe43
So other three is added for both
en
andfr
and vessel-view is update to use this new keys.